Skip to content

Conversation

yjp20
Copy link
Contributor

@yjp20 yjp20 commented Jul 7, 2025

No description provided.

@yjp20 yjp20 requested a review from RobertCraigie as a code owner July 7, 2025 18:37
Copy link
Contributor

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna rip the docs changes out to a separate PR

@RobertCraigie
Copy link
Contributor

RobertCraigie commented Jul 8, 2025

I think the modal could be a bit bigger?
Screenshot 2025-07-08 at 11 02 04 pm

and the spacing is a little off imo there should be more space above/below each key?

also the keys should be centered? the _ for space looks a bit off next to everything else

other than that the styling is quite nice

@RobertCraigie RobertCraigie changed the title feat: add titles to the docs pages feat: add which-key UI Jul 9, 2025
@RobertCraigie RobertCraigie force-pushed the main branch 2 times, most recently from c65cf6d to 3715729 Compare July 26, 2025 22:44
@RobertCraigie RobertCraigie force-pushed the youngjin/which-key branch 3 times, most recently from dcae9f0 to d99bdb4 Compare August 16, 2025 18:28
Co-Authored-By: Young-Jin Park <youngjinpark20@gmail.com>
@RobertCraigie
Copy link
Contributor

RobertCraigie commented Aug 16, 2025

Tweaked the styling a bit so it's simpler and just matches the commandline and made it a bit bigger
Screenshot 2025-08-16 at 10 34 30 pm

Copy link
Contributor

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

Co-Authored-By: Young-Jin Park <youngjinpark20@gmail.com>
@RobertCraigie RobertCraigie merged commit 5b8e41b into main Aug 16, 2025
1 check passed
@RobertCraigie RobertCraigie deleted the youngjin/which-key branch August 16, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants