-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] render-portal, replaces in-element for wormhole support #334
Conversation
toJSON(): OpcodeJSON { | ||
return { | ||
guid: this._guid, | ||
type: this.type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably am missing things here, but I didn't know enough to know what all should be here.
Tests are passing locally, on sauce labs, and on travis, but some vscode tslint build thing is erring out and kicking it a few times didn't help. |
@runspired If you go to |
@chadhietala thanks! |
@chancancode I can rebase this, but I'm pretty sure what I spiked here needs refinement. I'd love a review, and pointers in the right direction, so we can make sure that wormhole et al. using this technique have a good story in Glimmer. |
@runspired - I think we should probably close this specific PR (its out of date, and will be hard to bring it back into alignment with current master without just redoing the work), but we should make an issue that documents the shortfalls around |
Closing this as it seems to have gone stale. We're definitely still open to improving |
The
in-element
API provided by @rwjblue in #331 was insufficient to support ember-wormhole and flexi. I have not yet done work to see if this PR will fix flexi, but it does fix wormhole and I'm reasonably confident it at least gets us closer to supporting that library.in-element deficiencies
naming
The wormhole concept has often been referred to as a "portal" or "portal-ing" in other frameworks and in talks. I'm also particularly partial to the game Portal.