Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str-elevs client #176

Open
wants to merge 79 commits into
base: purgatory
Choose a base branch
from
Open

Str-elevs client #176

wants to merge 79 commits into from

Conversation

ChanoOT
Copy link

@ChanoOT ChanoOT commented Mar 10, 2016

A client class to read DEM pyramids is added (PyramidElevationDataProvider).
Changes in ElevationData and ShortBufferElevationData are done to save extra data from a DEM pyramid input file.
A new requestElevationData() method is added to make petitions based on tile information. Default behaviour redirects to the original method, the new class uses this implementation.
Minor changes in PlanetTileTesselator are done to make tile mesh resolution variable, according to the incoming elevationData. Default resolution is still the one given by TilesRenderParameters.
Minor changes in TileElevationDataRequest are introduced to call the new requestElevationData() method.
Minor changes in Tile are introduced to cancel elevation requests which are no longer needed.
Demo examples are introduced for every platform.

@ChanoOT
Copy link
Author

ChanoOT commented Mar 17, 2016

@DiegoGomezDeck New changes done:

  • Refactor of elevationDataRequest() methods into one which uses Tile pointer.
  • Refactor of JSON-like DEM formatting parser so it is now placed in an external "JSONDemParser" class, as happens with BilParser.
  • Correction of new code in tile.prune(), ensuring no memory errors will be produced.
  • Removal of code warnings. Introducing some user-defined warnings in places to be improved in the future.
  • Improving style-related issues and renaming of some elevationData extra fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants