Add MarshalJSON function to raw.BSON #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @SteelPhase I'm up for this - I can see how it might help the users of We're pretty strict on tests for maintainability though, would you mind adding a couple for this? A happy-path test and a couple edge cases, preferably table driven? Thanks for the PR! |
SteelPhase
force-pushed
the
patch-1
branch
2 times, most recently
from
993b02a
to
fb7d9ec
Compare
|
Yeah. i'll look into adding tests. |
|
Hi @SteelPhase I'm going to close this because it's been a couple months - we'll still happily accept it if you have the time to add tests though. Dom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #107 using the example provided in the issue.