Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare v0.3.3 release #603

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Prepare v0.3.3 release #603

merged 2 commits into from
Mar 18, 2021

Conversation

jsnel
Copy link
Member

@jsnel jsnel commented Mar 18, 2021 •
edited
Loading

Bumped version to v0.3.3 and added release notes

v0.3.3 release notes draft:

@jsnel
Prepare v0.3.3 release
a46a6d3 
Bumped version and added release notes
@jsnel jsnel requested a review from s-weigand March 18, 2021 03:42
@jsnel jsnel self-assigned this Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021 •
edited
Loading

Codecov Report

Merging #603 (2c0fbd9) into maintenance/v0.3 (67dacce) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@               Coverage Diff                @@
##           maintenance/v0.3    #603   +/-   ##
================================================
  Coverage              74.1%   74.1%           
================================================
  Files                    58      58           
  Lines                  3383    3383           
  Branches                637     637           
================================================
  Hits                   2510    2510           
  Misses                  732     732           
  Partials                141     141
Impacted Files Coverage Δ
glotaran/__init__.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67dacce...2c0fbd9. Read the comment docs.

s-weigand
s-weigand approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@s-weigand s-weigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnel
Update readme
2c0fbd9 
Clarified Python version support
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 18, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.00 ⭐ 1.00 ⭐ 0.00
Method Length 47.00 ⭐ 47.00 ⭐ 0.00
Working memory 4.00 ⭐ 4.00 ⭐ 0.00
Quality 90.24% ⭐ 90.24% ⭐ 0.00%
Other metrics Before After Change
Lines 23 23 0
Changed files Quality Before Quality After Quality Change
glotaran/init.py 90.24% ⭐ 90.24% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jsnel jsnel merged commit 24fcd33 into glotaran:maintenance/v0.3 Mar 18, 2021
@jsnel jsnel deleted the maintenance/rel_notes_v0.3.3 branch March 18, 2021 20:57
jsnel added a commit to jsnel/pyglotaran that referenced this pull request Mar 28, 2021
@jsnel
Prepare v0.3.3 release (glotaran#603)
0e1ddce 
* Prepare v0.3.3 release

Bumped version and added release notes

* Update readme

Clarified Python version support
jsnel added a commit to jsnel/pyglotaran that referenced this pull request Mar 28, 2021
@jsnel
Prepare v0.3.3 release (glotaran#603)
e9dbda0 
* Prepare v0.3.3 release

Bumped version and added release notes

* Update readme

Clarified Python version support
jsnel added a commit to jsnel/pyglotaran that referenced this pull request Mar 28, 2021
@jsnel
Prepare v0.3.3 release (glotaran#603)
dbc5be5 
* Prepare v0.3.3 release

Bumped version and added release notes

* Update readme

Clarified Python version support
jsnel added a commit that referenced this pull request Mar 28, 2021
@jsnel
Maintenance/forward port v0.3.3 changes (#618)
0d41d63 
* Prepare v0.3.3 release (#603)
Bumped version and added release notes

* Maintenance/patches for v0.3.3 (#599) 1/2
* Remove unneeded check in spectral_penalties._get_area Fixes #598
* Maintenance/patches for v0.3.3 (#599) 2/2
* Force recalculation of SVD attributes in scheme._prepare_data Fixes #597
* 🔨 Remove no-op code related to new_dims
Changes that were lost because code was moved from scheme.py to problem.py

* Add a Zenodo config file
Added config file based on the example generated by zenodo
JSON Export example found at: https://zenodo.org/account/settings/github/repository/glotaran/pyglotaran#
Closes #579

* Update readme
Clarified Python version support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-weigand s-weigand s-weigand approved these changes

Assignees

@jsnel jsnel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsnel @s-weigand