Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_SyncedList dictionary children should be _SyncedDicts #196

Closed
bdice opened this issue May 20, 2019 · 0 comments · Fixed by #484
Closed

_SyncedList dictionary children should be _SyncedDicts #196

bdice opened this issue May 20, 2019 · 0 comments · Fixed by #484
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bdice
Copy link
Member

bdice commented May 20, 2019

Description

I was editing a job document. When getting a list that is a child of a _SyncedDict, you get a _SyncedList. However, when getting a dict that is a child of a _SyncedList, you don't get a _SyncedDict (just a dict).

To reproduce

import signac

project = signac.init_project('test')
project.doc['key'] = [{'a': 1}, {'b': 2}]
print(type(project.doc.key))
print(type(project.doc.key[0]))

project.doc.key[0]['a'] = 3
assert project.doc.key[0]['a'] == 3  # still 1
@csadorf csadorf added the bug Something isn't working label May 24, 2019
@csadorf csadorf added this to the v1.1.1 milestone May 24, 2019
@bdice bdice self-assigned this May 25, 2019
@csadorf csadorf modified the milestones: v1.1.1, v1.1.2 Jul 7, 2019
@bdice bdice removed this from the v1.2.1 milestone Dec 4, 2019
@bdice bdice added this to the v2.0.0 milestone Mar 16, 2020
@vyasr vyasr mentioned this issue Jan 27, 2021
12 tasks
@bdice bdice modified the milestones: v2.0.0, 1.7.0 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants