Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate E2E tests into a dedicated CI env. #17154

Merged

Conversation

AdrienClairembault
Copy link
Contributor

@AdrienClairembault AdrienClairembault commented May 21, 2024

As discussed in our weekly meeting.

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@AdrienClairembault AdrienClairembault marked this pull request as ready for review May 22, 2024 07:09
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@AdrienClairembault
Copy link
Contributor Author

My bad, I missing what you meant for the env.skip != 'true' comment.
Thanks for fixing it yourself 👍

@cedric-anne cedric-anne merged commit afe3ddb into glpi-project:main May 23, 2024
9 checks passed
@AdrienClairembault AdrienClairembault deleted the feature/separate-e2e-tests branch May 23, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants