fix: fixes bug, with already loggin users, then left, an exception wa…

…s thrown
gluecode-it · Oct 3, 2020 · 5d6f3ec · 5d6f3ec
1 parent 1358435
commit 5d6f3ec
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/index.spec.ts b/src/index.spec.ts
@@ -219,6 +219,21 @@ describe("StartStopServerByDiscordVoiceChannel", () => {
       handler.start();
     });
 
+    it("check startToStopTransitionHandler does not throw error", async (done) => {
+      const emitter = new EventEmitter();
+      observer.onThresholdReached?.mockImplementationOnce(() => {});
+      observer.onThresholdLeft?.mockImplementationOnce(
+        (threshold: number, callback: () => void) => {
+          emitter.on("triggerLeft", callback);
+        }
+      );
+      handler.onceStopFinished(() => {
+        done();
+      });
+      await handler.start();
+      emitter.emit("triggerLeft");
+    });
+
     it("should send if running", () => {
       vmHandler.onStarted?.mockImplementationOnce(
         (callback: (ip: string) => void) => {

diff --git a/src/index.ts b/src/index.ts
@@ -147,7 +147,9 @@ export class DiscordVoiceChannelServerHandler {
 
     this.stopToStartTransitionHandler.onTransitionFinished(async () => {
       await this.messageHandler.sendStopMessage();
-      this.startToStopTransitionHandler.reset();
+      if (this.startToStopTransitionHandler.is(State.STATUS_B)) {
+        this.startToStopTransitionHandler.reset();
+      }
       this.emitter.emit(Event.STOP_FINISHED);
     });