Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Default --sort-columns to source primary key for BigQuery target #224

Merged
merged 4 commits into from
Aug 23, 2024
Merged

feat: Default --sort-columns to source primary key for BigQuery target #224

merged 4 commits into from
Aug 23, 2024

Conversation

nj1973
Copy link
Collaborator

@nj1973 nj1973 commented Aug 21, 2024

This PR enables code to default --sort-columns to source primary key for BigQuery target.

It also adds a magic value of NONE to request no sort columns.

@nj1973 nj1973 linked an issue Aug 21, 2024 that may be closed by this pull request
BigQuery offloads should consider seeding sort columns with source primary key #170
Closed
@nj1973 nj1973 requested a review from ssenior45 August 23, 2024 14:33
@nj1973 nj1973 merged commit fd43124 into main Aug 23, 2024
7 checks passed
@nj1973 nj1973 deleted the 170-bigquery-seed-sort-columns branch August 23, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssenior45 ssenior45 ssenior45 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery offloads should consider seeding sort columns with source primary key
2 participants
@nj1973 @ssenior45