ec: IO failure when shrinking dispersed volume during io running #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IO Failures are found when performing a shrink operation on a
distributed-dispersed volume, while IO is in progress.
RCA: During rebalance operation execution while layout has changed
dht_creaete_cbk retry create operation under lock in 2nd attempt.
It takes decision based on error set by posix_create in xdata
in first attempt. ec(ec_manager_create) does not pass xdata to the
upper xlator so dht_create is not able to take decision to
reattempt fop creation in case if layout has changed and throw
an EIO error.
Solution: Pass the xdata to the upper xlator to avoid an issue.
Fixes: gluster#2947
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
|
/run regression |
xhernandez
requested changes
Nov 12, 2021
| @@ -228,11 +228,14 @@ ec_manager_create(ec_fop_data_t *fop, int32_t state) | |||
| case -EC_STATE_DISPATCH: | |||
| case -EC_STATE_PREPARE_ANSWER: | |||
| case -EC_STATE_REPORT: | |||
| cbk = fop->answer; | |||
|
|
|||
| GF_ASSERT(cbk != NULL); | |||
There was a problem hiding this comment.
That's not guaranteed. cbk may be NULL if there are not enough consistent bricks or the operation has failed early for some other reason.
| GF_ASSERT(fop->error != 0); | ||
|
|
||
| if (fop->cbks.create != NULL) { | ||
| fop->cbks.create(fop->req_frame, fop, fop->xl, -1, fop->error, | ||
| NULL, NULL, NULL, NULL, NULL, NULL); | ||
| NULL, NULL, NULL, NULL, NULL, cbk->xdata); |
There was a problem hiding this comment.
Suggested change
| NULL, NULL, NULL, NULL, NULL, cbk->xdata); | |
| NULL, NULL, NULL, NULL, NULL, cbk == NULL ? NULL : cbk->xdata); |
Fixes: gluster#2947 Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
|
/run regression |
xhernandez
approved these changes
Nov 12, 2021
|
1 test(s) failed 0 test(s) generated core 5 test(s) needed retry |
|
/run regression |
mohit84
added a commit
to mohit84/glusterfs
that referenced
this pull request
Nov 15, 2021
…ster#2948) * ec: IO failure when shrinking dispersed volume during io running IO Failures are found when performing a shrink operation on a distributed-dispersed volume, while IO is in progress. RCA: During rebalance operation execution while layout has changed dht_creaete_cbk retry create operation under lock in 2nd attempt. It takes decision based on error set by posix_create in xdata in first attempt. ec(ec_manager_create) does not pass xdata to the upper xlator so dht_create is not able to take decision to reattempt fop creation in case if layout has changed and throw an EIO error. Solution: Pass the xdata to the upper xlator to avoid an issue. > Fixes: gluster#2947 > Signed-off-by: Mohit Agrawal <moagrawa@redhat.com> > (Cherry picked from commit f81bf52) > (Reviewed on upstream link gluster#2948) Fixes: gluster#2947 Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Shwetha-Acharya
pushed a commit
that referenced
this pull request
Jan 7, 2022
…) (#2951) * ec: IO failure when shrinking dispersed volume during io running IO Failures are found when performing a shrink operation on a distributed-dispersed volume, while IO is in progress. RCA: During rebalance operation execution while layout has changed dht_creaete_cbk retry create operation under lock in 2nd attempt. It takes decision based on error set by posix_create in xdata in first attempt. ec(ec_manager_create) does not pass xdata to the upper xlator so dht_create is not able to take decision to reattempt fop creation in case if layout has changed and throw an EIO error. Solution: Pass the xdata to the upper xlator to avoid an issue. > Fixes: #2947 > Signed-off-by: Mohit Agrawal <moagrawa@redhat.com> > (Cherry picked from commit f81bf52) > (Reviewed on upstream link #2948) Fixes: #2947 Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IO Failures are found when performing a shrink operation on a
distributed-dispersed volume, while IO is in progress.
RCA: During rebalance operation execution while layout has changed
dht_creaete_cbk retry create operation under lock in 2nd attempt.
It takes decision based on error set by posix_create in xdata
in first attempt. ec(ec_manager_create) does not pass xdata to the
upper xlator so dht_create is not able to take decision to
reattempt fop creation in case if layout has changed and throw
an EIO error.
Solution: Pass the xdata to the upper xlator to avoid an issue.
Fixes: #2947
Signed-off-by: Mohit Agrawal moagrawa@redhat.com