-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSUB-347 weighted probabilistic threshold #814
Conversation
For full LLVM coverage report click here! |
Codecov Report
@@ Coverage Diff @@
## dev #814 +/- ##
==========================================
+ Coverage 78.06% 78.15% +0.08%
==========================================
Files 66 67 +1
Lines 10601 10649 +48
==========================================
+ Hits 8276 8323 +47
- Misses 2325 2326 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
blocked by #813 |
a6926b3
to
8916a67
Compare
40d6dc2
to
9e6e489
Compare
Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) from 29.2.1 to 29.3.1. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/commits/v29.3.1/packages/jest) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
9e6e489
to
a2708b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some questions around tests.
a2708b9
to
1b60ec2
Compare
Regarding the floating points... Nonetheless, I tried to get rid of it. I looked into parity's Not a strong argument but, Algorand uses FP in their main consensus in the same 'sortition' use case and Algorand has a strong peer-reviewed background. Maybe the use of FLOPS in this context is justified. Help is welcomed, this is how far I've got. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, still looking at the floating point stuff so I'll leave comments on that later
ba8d3ea
to
b38a756
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now. I will follow up with test related changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of proposed changes:
Generate a fraction weighted by stake and a sample size fraction parameter.
Practical tips for PR review & merge: