CSUB-264 Palletizing Creditcoin's offchain worker #813

CAGS295 · 2022-12-13T19:42:40Z

Description of proposed changes:

Practical tips for PR review & merge:

All GitHub Actions report PASS
Newly added code/functions have unit tests
- Coverage tools report all newly added lines as covered
- The positive scenario is exercised
- Negative scenarios are exercised, e.g. assert on all possible errors
- Assert on events triggered if applicable
- Assert on changes made to storage if applicable
Modified behavior/functions - try to make sure above test items are covered
Integration tests are added if applicable/needed

github-actions · 2022-12-13T20:06:48Z

For full LLVM coverage report click here!

codecov-commenter · 2022-12-13T20:15:10Z

Codecov Report

Merging #813 (262daf8) into dev (2c25748) will decrease coverage by 0.33%.
The diff coverage is 93.84%.

❗ Current head 262daf8 differs from pull request most recent head 013aab3. Consider uploading reports for the commit 013aab3 to get more accurate results

@@            Coverage Diff             @@
##              dev     #813      +/-   ##
==========================================
- Coverage   78.24%   77.91%   -0.34%     
==========================================
  Files          51       65      +14     
  Lines       10317    10487     +170     
==========================================
+ Hits         8073     8171      +98     
- Misses       2244     2316      +72

Impacted Files	Coverage Δ
node/rpc/src/task.rs	`82.22% <ø> (ø)`
node/src/rpc.rs	`0.00% <ø> (ø)`
node/src/service/nonce_monitor.rs	`0.00% <0.00%> (ø)`
pallets/creditcoin/src/migrations/mod.rs	`0.00% <0.00%> (ø)`
pallets/creditcoin/src/ocw.rs	`96.00% <ø> (-0.50%)`	⬇️
pallets/creditcoin/src/ocw/errors.rs	`58.33% <0.00%> (-19.45%)`	⬇️
pallets/creditcoin/src/ocw/rpc.rs	`78.61% <ø> (-3.78%)`	⬇️
pallets/creditcoin/src/types.rs	`91.11% <0.00%> (-1.42%)`	⬇️
...ets/offchain-task-scheduler/runtime-api/src/lib.rs	`42.85% <ø> (ø)`
pallets/offchain-task-scheduler/src/tasks/error.rs	`0.00% <0.00%> (ø)`
... and 40 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

atodorov

A few minor requests as I review more.

pallets/offchain-task-scheduler/src/ocw/nonce.rs

pallets/offchain-task-scheduler/src/ocw.rs

pallets/creditcoin/src/migrations/v7.rs

nathanwhit

LGTM

.github/workflows/bench.yml

runtime/src/lib.rs

pallets/offchain-task-scheduler/src/ocw/tests.rs

atodorov

LGTM as well.

nathanwhit · 2022-12-21T19:23:58Z

Looks like the merge of #827 created some conflicts that need resolution before we can merge this @CAGS295

task pallet

* Connect task-scheduler interface * move IntoBounded to extensions * migrate `PendingTasks` storage * remove make id functions in favor of From impl * types: transfers * types: CollectedCoins * fix duplicated id constructors * mocked runtime * Authority Interface * port nonce tests * updated legacy transfers now use the new task-scheduler + remove old Task's implementations + leak transfer's inner_hash for testing * fix `register_transfer_ocw_fail_to_send` * use task-scheduler in creditcoin's mocked runtime * port `offchain_signed_tx_works` * `remove_authority_works_for_root() fix`+ `add_authority_works_for_root` * port `offchain_worker_logs_error_when_transfer_validation_errors` * port `effective_guard_lifetime_until_task_expiration` * port `completed_oversubscribed_tasks_are_skipped` * port `ocw_retries` * port` task_deadline_oversubscription` * port `offchain_worker_should_log_and_forget_guard_when_task_is_already_handled` * rename `duplicate_retry_fail_and_succeed` * change keystore id to 'gots' * move task-scheduler * Benchmarks * Update pallets/offchain-task-scheduler/src/ocw/tests.rs Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com> * remove unused code * consistent weight update in `migrate` Co-authored-by: Alexander Todorov <alex.todorov@gluwa.com> Update creditcoin-js interface format

for more information, see https://pre-commit.ci

CAGS295 force-pushed the feature/CSUB-264 branch from 16fc6b2 to 10abdbc Compare December 13, 2022 19:45

CAGS295 force-pushed the feature/CSUB-264 branch from 8a967ba to 2e9273b Compare December 13, 2022 22:01

CAGS295 marked this pull request as ready for review December 13, 2022 22:43

CAGS295 force-pushed the feature/CSUB-264 branch from 262daf8 to 013aab3 Compare December 13, 2022 22:44

atodorov requested changes Dec 15, 2022

View reviewed changes

pallets/offchain-task-scheduler/src/ocw/nonce.rs Show resolved Hide resolved

pallets/offchain-task-scheduler/src/ocw.rs Show resolved Hide resolved

pallets/creditcoin/src/migrations/v7.rs Show resolved Hide resolved

atodorov reviewed Dec 15, 2022

View reviewed changes

pallets/creditcoin/src/migrations/v7.rs Show resolved Hide resolved

nathanwhit reviewed Dec 16, 2022

View reviewed changes

.github/workflows/bench.yml Outdated Show resolved Hide resolved

runtime/src/lib.rs Outdated Show resolved Hide resolved

pallets/offchain-task-scheduler/src/ocw/tests.rs Outdated Show resolved Hide resolved

CAGS295 force-pushed the feature/CSUB-264 branch from 3fdadeb to f13f52e Compare December 19, 2022 21:20

CAGS295 mentioned this pull request Dec 19, 2022

CSUB-348 Simplify associated signing types #815

Merged

9 tasks

CAGS295 force-pushed the feature/CSUB-264 branch from 274e011 to f889f74 Compare December 19, 2022 21:24

CAGS295 mentioned this pull request Dec 19, 2022

CSUB-347 weighted probabilistic threshold #814

Merged

9 tasks

atodorov previously approved these changes Dec 20, 2022

View reviewed changes

nathanwhit previously approved these changes Dec 20, 2022

View reviewed changes

CAGS295 dismissed stale reviews from nathanwhit and atodorov via 1d3e76e December 20, 2022 22:35

CAGS295 force-pushed the feature/CSUB-264 branch 2 times, most recently from 1d3e76e to 34b20fe Compare December 20, 2022 22:54

CAGS295 mentioned this pull request Dec 21, 2022

Nightly clippy 0.1.68 (d0dc9ef 2022-12-18) #827

Merged

CAGS295 force-pushed the feature/CSUB-264 branch from 34b20fe to 39f8060 Compare December 21, 2022 05:20

atodorov previously approved these changes Dec 21, 2022

View reviewed changes

nathanwhit previously approved these changes Dec 21, 2022

View reviewed changes

CAGS295 dismissed stale reviews from nathanwhit and atodorov via 5794559 December 21, 2022 22:17

CAGS295 force-pushed the feature/CSUB-264 branch from 39f8060 to 5794559 Compare December 21, 2022 22:17

nathanwhit previously approved these changes Dec 21, 2022

View reviewed changes

CAGS295 added 2 commits December 21, 2022 15:53

task interface

886e403

task pallet

Runtime api

7bb3bc6

CAGS295 added 2 commits December 21, 2022 15:53

Add benchmark config section in CI for task-scheduler

057cda6

Authority Interface

2b051ec

nathanwhit dismissed their stale review via ba5c058 December 21, 2022 23:57

nathanwhit force-pushed the feature/CSUB-264 branch from 5794559 to ba5c058 Compare December 21, 2022 23:57

nathanwhit previously approved these changes Dec 21, 2022

View reviewed changes

nathanwhit enabled auto-merge (rebase) December 21, 2022 23:58

CAGS295 and others added 5 commits December 21, 2022 17:42

bump runtime version

8312c32

Auto-update creditcoin-js type definitions

de23f84

missing coverage from offchain_signed_tx

345575c

[pre-commit.ci] auto fixes from pre-commit.com hooks

5c53c1d

for more information, see https://pre-commit.ci

nathanwhit dismissed their stale review via 5c53c1d December 22, 2022 01:42

nathanwhit force-pushed the feature/CSUB-264 branch from ba5c058 to 5c53c1d Compare December 22, 2022 01:42

nathanwhit approved these changes Dec 22, 2022

View reviewed changes

CAGS295 requested a review from atodorov December 22, 2022 15:56

atodorov approved these changes Dec 23, 2022

View reviewed changes

nathanwhit merged commit d21ef32 into dev Dec 23, 2022

nathanwhit deleted the feature/CSUB-264 branch December 23, 2022 09:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CSUB-264 Palletizing Creditcoin's offchain worker #813

CSUB-264 Palletizing Creditcoin's offchain worker #813

CAGS295 commented Dec 13, 2022 •

edited by atodorov

Loading

github-actions bot commented Dec 13, 2022

codecov-commenter commented Dec 13, 2022 •

edited

Loading

atodorov left a comment

nathanwhit left a comment

atodorov left a comment

nathanwhit commented Dec 21, 2022

CSUB-264 Palletizing Creditcoin's offchain worker #813

CSUB-264 Palletizing Creditcoin's offchain worker #813

Conversation

CAGS295 commented Dec 13, 2022 • edited by atodorov Loading

github-actions bot commented Dec 13, 2022

codecov-commenter commented Dec 13, 2022 • edited Loading

Codecov Report

atodorov left a comment

Choose a reason for hiding this comment

nathanwhit left a comment

Choose a reason for hiding this comment

atodorov left a comment

Choose a reason for hiding this comment

nathanwhit commented Dec 21, 2022

CAGS295 commented Dec 13, 2022 •

edited by atodorov

Loading

codecov-commenter commented Dec 13, 2022 •

edited

Loading