Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly clippy 0.1.68 (d0dc9ef 2022-12-18) #827

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Nightly clippy 0.1.68 (d0dc9ef 2022-12-18) #827

merged 1 commit into from
Dec 21, 2022

Conversation

CAGS295
Copy link
Contributor

@CAGS295 CAGS295 commented Dec 19, 2022

Description of proposed changes:

Some clippy fixes from nightly.

Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe modify ci/env as well? Otherwise we're using nightly-2022-09-01 in CI.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Merging #827 (72774af) into dev (0ebfe3e) will decrease coverage by 0.00%.
The diff coverage is 85.13%.

@@            Coverage Diff             @@
##              dev     #827      +/-   ##
==========================================
- Coverage   78.24%   78.24%   -0.01%     
==========================================
  Files          51       51              
  Lines       10317    10371      +54     
==========================================
+ Hits         8073     8115      +42     
- Misses       2244     2256      +12     
Impacted Files Coverage Δ
node/src/benchmarking.rs 0.00% <0.00%> (ø)
node/src/chain_spec.rs 0.00% <0.00%> (ø)
node/src/cli.rs 35.71% <0.00%> (+1.16%) ⬆️
node/src/service.rs 0.00% <0.00%> (ø)
pallets/creditcoin/src/ocw/tasks.rs 100.00% <ø> (ø)
sha3pow/src/lib.rs 94.38% <0.00%> (ø)
pallets/creditcoin/src/ocw/rpc.rs 82.38% <50.00%> (ø)
pallets/creditcoin/src/ocw/tasks/collect_coins.rs 98.95% <50.00%> (+<0.01%) ⬆️
node/rpc/src/task.rs 82.60% <100.00%> (+0.38%) ⬆️
pallets/creditcoin/src/helpers.rs 100.00% <100.00%> (ø)
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

For full LLVM coverage report click here!

@CAGS295 CAGS295 force-pushed the nightly-clippy branch 2 times, most recently from 4be8e5c to cf314e9 Compare December 20, 2022 22:52
@atodorov atodorov merged commit 90cb123 into dev Dec 21, 2022
@atodorov atodorov deleted the nightly-clippy branch December 21, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants