Create getter and setter for MarketplaceService.Stubbed #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migueleliasweb
force-pushed
the
workarond-marketplace-interface-stubbed
branch
from
8f1d144 to
bacddd1
Compare
gmlewis
reviewed
Apr 4, 2021
| MarketplacePendingChange *MarketplacePendingChange `json:"marketplace_pending_change,omitempty"` | ||
| } | ||
|
|
||
| func (s *MarketplaceService) SetStubbed(stubbed bool) { |
There was a problem hiding this comment.
These two new methods need standard godoc-style comment strings.
There was a problem hiding this comment.
I don't know how I managed to miss this 😔
There was a problem hiding this comment.
Done, added the doc strings
gmlewis
requested changes
Apr 4, 2021
There was a problem hiding this comment.
Thank you, @migueleliasweb .
Sorry to be a pain, but please make the comments complete sentences per idiomatic Go style for the auto-generated godocs.
github/apps_marketplace.go
Outdated
| MarketplacePendingChange *MarketplacePendingChange `json:"marketplace_pending_change,omitempty"` | ||
| } | ||
|
|
||
| // SetStubbed configures MarketplaceService Stubbed property |
There was a problem hiding this comment.
Suggested change
| // SetStubbed configures MarketplaceService Stubbed property | |
| // SetStubbed configures the MarketplaceService Stubbed property. |
There was a problem hiding this comment.
Sorry again to be a pain, but can you please add the ending periods in both cases as shown in the suggested changes?
github/apps_marketplace.go
Outdated
| s.Stubbed = stubbed | ||
| } | ||
|
|
||
| // GetStubbed returns MarketplaceService Stubbed property |
There was a problem hiding this comment.
Suggested change
| // GetStubbed returns MarketplaceService Stubbed property | |
| // GetStubbed returns the MarketplaceService Stubbed property. |
migueleliasweb
force-pushed
the
workarond-marketplace-interface-stubbed
branch
2 times, most recently
from
5bc6f47 to
ce74d52
Compare
migueleliasweb
force-pushed
the
workarond-marketplace-interface-stubbed
branch
from
ce74d52 to
b201be0
Compare
gmlewis
approved these changes
Apr 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MarketplaceService.GetStubbedandMarketplaceService.SetStubbed