Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix demo/boards/README, fix typos and change to a local node #1034

Merged

Conversation

jefft0
Copy link
Contributor

@jefft0 jefft0 commented Aug 8, 2023

The README for demo/boards shows how to create a key and interact with the "boards" realm. It was originally written for the testnet, but the testnet faucet doesn't work anymore. So, in this pull request we:

  • Rewrite the README to explain how to run a local node by adding $GNOT to genesis_balances.txt . (Also mention the README for running a local faucet.)
  • Add the step to Register with /r/demo/users which must be done before creating a board.
  • Fix the links for viewing interactive documentation on the testnet.
  • For consistency in the README and with the online help, change --recover to -recover, etc. with one dash.
  • Remove the instructions to publish the realm since it is already included in the node genesis (and on the testnet).

(NOTE: This PR is a follow-up to #1030 which was already approved but is much smaller.)
(NOTE: This PR is an alternative to #831 which can be closed.)

@jefft0 jefft0 requested a review from a team as a code owner August 8, 2023 15:01
@jefft0 jefft0 marked this pull request as draft August 8, 2023 15:01
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Aug 8, 2023
@jefft0 jefft0 force-pushed the fix/demo_boards_README-local-node-and-typos branch 2 times, most recently from 1dc2aac to 9556c5a Compare August 8, 2023 15:17
@jefft0 jefft0 marked this pull request as ready for review August 9, 2023 09:29
@jefft0 jefft0 force-pushed the fix/demo_boards_README-local-node-and-typos branch 2 times, most recently from b4e4f2a to 1c543ae Compare August 9, 2023 12:22
… the PR for details.

Signed-off-by: Jeff Thompson <jeff@thefirst.org>
@jefft0 jefft0 force-pushed the fix/demo_boards_README-local-node-and-typos branch from 1c543ae to 25a087d Compare August 9, 2023 12:32
Co-authored-by: Iuri Pereira <iuricmp@gmail.com>
@moul moul changed the title fix: In demo/boards/README, fix typos and change to a local node. docs: fix demo/boards/README, fix typos and change to a local node. Aug 10, 2023
@moul moul changed the title docs: fix demo/boards/README, fix typos and change to a local node. docs: fix demo/boards/README, fix typos and change to a local node Aug 10, 2023
@moul moul merged commit ffe18b0 into gnolang:master Aug 10, 2023
6 of 7 checks passed
@jefft0 jefft0 mentioned this pull request Aug 10, 2023
Doozers pushed a commit to Doozers/gno that referenced this pull request Aug 31, 2023
…nolang#1034)

Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Iuri Pereira <iuricmp@gmail.com>
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 18, 2023
thehowl pushed a commit that referenced this pull request Nov 20, 2023
…be test3 (#1384)

This is a follow-up to PR #1034 which updated the documentation in
demo/boards/README.md . The chainid for test3.gno.land should be "test3"
(not "testnet").

Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants