fix: boolean operations must have boolean operands #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1451 +/- ##
==========================================
- Coverage 56.05% 56.05% -0.01%
==========================================
Files 421 421
Lines 65457 65459 +2
==========================================
Hits 36692 36692
- Misses 25897 25898 +1
- Partials 2868 2869 +1 ☔ View full report in Codecov by Sentry. |
jaekwon
approved these changes
Dec 18, 2023
|
also related to #1424 |
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
<!-- please provide a detailed description of the changes made in this pull request. --> Addresses gnolang#1083 This fixes an issue where there was no enforcement of operand types when doing boolean operations. The correct approach should be to verify boolean operand type expressions also evaluate to boolean typed values before proceeding. This prevents any of the behavior described in the issue that this PR addresses. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1083
This fixes an issue where there was no enforcement of operand types when doing boolean operations. The correct approach should be to verify boolean operand type expressions also evaluate to boolean typed values before proceeding. This prevents any of the behavior described in the issue that this PR addresses.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description