chore: update CODEOWNERS #1545
Merged
chore: update CODEOWNERS #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehowl
reviewed
Jan 17, 2024
There was a problem hiding this comment.
just a few proposals. looks better 👍
I would like as much as possible to have places where the codeowner is tech-staff to be exceptions and/or rarely touched parts of the code, or at least work to minimize them over time (this PR is already going in the right direction definitely).
By reducing tech-staff over time, we can make the "review-requested" filter on GH more useful, and fine-tune our notifs better :)
| gnovm/pkg/gnomod @harry-hov | ||
| gnovm/pkg/integration @gfanton | ||
| #gnovm/pkg/gnoenv | ||
| #gnovm/pkg/repl |
zivkovicmilos
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Looks good 💯
I haven't found anything out of place; @thehowl's suggestions make sense to me. I especially like the suggestion for giving full ownership of the docs to the devrel team (right now, our (core team) review always supersedes them)
Co-authored-by: Morgan <morgan@morganbaz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the pull request open to receive feedback and suggestions for changes.