feat(txtar): handle quote for gnokey #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1745 +/- ##
==========================================
- Coverage 47.41% 44.72% -2.70%
==========================================
Files 384 456 +72
Lines 61187 67543 +6356
==========================================
+ Hits 29014 30209 +1195
- Misses 29744 34806 +5062
- Partials 2429 2528 +99 ☔ View full report in Codecov by Sentry. |
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
deelawn
approved these changes
Mar 7, 2024
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
zivkovicmilos
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1736
This PR updates the
gnokeycommand to better handle quotes withintxtar. This is useful for commands likequery:gnokey query vm/qrender --data "gno.land/r/append\n"The update means
gnokeycan now handle:• Arguments in quotes that contain spaces or special characters.
• Escape sequences inside quotes.
See tests for more concrete examples.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description