Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add todolist package & realm #1811

Merged
merged 15 commits into from
Apr 11, 2024

Conversation

MalekLahbib
Copy link
Contributor

@MalekLahbib MalekLahbib commented Mar 21, 2024

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@moul
Copy link
Member

moul commented Mar 21, 2024

cc @gnolang/devrels

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Mar 21, 2024
@moul moul requested a review from a team March 21, 2024 17:27
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.08%. Comparing base (ca6566f) to head (1963b82).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1811      +/-   ##
==========================================
- Coverage   47.79%   45.08%   -2.71%     
==========================================
  Files         393      464      +71     
  Lines       61654    68008    +6354     
==========================================
+ Hits        29465    30662    +1197     
- Misses      29717    34772    +5055     
- Partials     2472     2574     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MalekLahbib MalekLahbib changed the title Added todolist pkg and realm feat: Added todolist pkg and realm Mar 22, 2024
@MalekLahbib
Copy link
Contributor Author

To devteam: it's a little bit difficult to understand all the tests, and to read the results. Some errors were repeated 2 times (2 tests gave the same errors).

@MalekLahbib MalekLahbib marked this pull request as ready for review March 22, 2024 14:53
@MalekLahbib MalekLahbib requested a review from a team as a code owner March 22, 2024 14:53
@MalekLahbib
Copy link
Contributor Author

added a fix to ufmt so that the unicode emojis can be displayed correctly, pushed to my fork. I don't know if the merge will add that modification too

@leohhhn
Copy link
Contributor

leohhhn commented Mar 25, 2024

Hey @MalekLahbib, thanks for your work. I see that this PR also includes both the todo-list app, as well as the ufmt multi-byte fix. Can you please separate this into two PRs, so that the PRs are scoped correctly?

I suggest you checkout a new branch from master and implement the ufmt change there, while deleting the change here and only working on the todo-list app.

@MalekLahbib
Copy link
Contributor Author

Hey @leohhhn, thanks for your message, a lot of github things are new to me, so I'm still learning. I noticed when I pushed the ufmt solution that it was on the same PR and didn't know what to do. I 'm gonna try to figure out what you told me to do by myself. If I have difficulties I'll ask for help.

@leohhhn leohhhn self-requested a review March 26, 2024 12:06
@leohhhn leohhhn changed the title feat: Added todolist pkg and realm feat(examples): add todolist package & realm Mar 26, 2024
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing this example! Please resolve the comments before we can merge :)

Also, you can consider adding tests for the realm itself.

examples/gno.land/p/demo/todolist/todolist.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/todolist/todolist.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/todolist/todolist.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/todolist/todolist.gno Outdated Show resolved Hide resolved
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🙏

examples/gno.land/r/demo/todolist/todolist.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/todolist/todolist.gno Outdated Show resolved Hide resolved
@zivkovicmilos
Copy link
Member

@MalekLahbib Please check why the examples tests are failing 🙏

cc @leohhhn

@MalekLahbib
Copy link
Contributor Author

@MalekLahbib Please check why the examples tests are failing 🙏

cc @leohhhn

I sent on signal about this issue, @leohhhn asked me to commit so he can have my code. Here's a screenshot of what I have as an error msg:

Screenshot from 2024-03-29 10-35-19

@MalekLahbib
Copy link
Contributor Author

@leohhhn @zivkovicmilos all tests passed this time, can you check again and tell me if there's other things to modify? the realm test file worked locally for me. Thanks

@zivkovicmilos zivkovicmilos merged commit aab9f4f into gnolang:master Apr 11, 2024
188 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants