Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove gnofaucet leftover from gno.land Make #1957

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

zivkovicmilos
Copy link
Member

Description

This PR removes the build.gnofaucet directive from the gno.land Makefile

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos self-assigned this Apr 19, 2024
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Apr 19, 2024
@thehowl thehowl changed the title hotfix: remove gnofaucet leftover from gno.land Make fix: remove gnofaucet leftover from gno.land Make Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.78%. Comparing base (5a976ef) to head (2aa41da).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1957      +/-   ##
==========================================
+ Coverage   45.18%   47.78%   +2.59%     
==========================================
  Files         465      393      -72     
  Lines       68081    61602    -6479     
==========================================
- Hits        30763    29437    -1326     
+ Misses      34742    29695    -5047     
+ Partials     2576     2470     -106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gfanton gfanton merged commit 7ecc692 into gnolang:master Apr 19, 2024
185 of 188 checks passed
@zivkovicmilos zivkovicmilos deleted the hotfix/remove-gnofaucet-make branch April 19, 2024 12:22
omarsy pushed a commit to TERITORI/gno that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants