-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Dockerfile in the contribs folder with gnodev and gnofaucet #2009
Conversation
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
To speed up Docker builds, we can apply @D4ryl00's method for building contribs to build gnofaucet. This approach leverages cache reuse and streamlines the Go mod download process. |
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
Status: Revisit when the docker support is updated. |
@D4ryl00 can you pull in the latest master changes and resolve conflicts? |
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2009 +/- ##
=======================================
Coverage 54.61% 54.61%
=======================================
Files 581 581
Lines 77962 77962
=======================================
Hits 42579 42579
Misses 32205 32205
Partials 3178 3178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@zivkovicmilos I've merged master and resolved conflicts. |
@zivkovicmilos I think we should use goreleaser as we are doing for other contribs projects. |
We should use |
This PR:
contribs
folder to buildgnodev
andgnofaucet
. We thinkgnodev
should be deployed easily since it is an unavoidable tool to code realms.curl
in theruntime-base
layer. When we have multiple services in a docker-compose.yml file, we want that some services start before others. For instance, tx-indexer is dependent on gnodev, so we want to start tx-indexer only when gnodev is ready. To do that, docker has a healthy status that can be set when a command succeeds. That's why I addedcurl
, to test if gnodev can be reach.Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description