Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dockerfile in the contribs folder with gnodev and gnofaucet #2009

Closed
wants to merge 6 commits into from

Conversation

D4ryl00
Copy link
Contributor

@D4ryl00 D4ryl00 commented Apr 30, 2024

This PR:

  1. adds a Dockerfile in the contribs folder to build gnodev and gnofaucet. We think gnodev should be deployed easily since it is an unavoidable tool to code realms.
  2. adds curl in the runtime-base layer. When we have multiple services in a docker-compose.yml file, we want that some services start before others. For instance, tx-indexer is dependent on gnodev, so we want to start tx-indexer only when gnodev is ready. To do that, docker has a healthy status that can be set when a command succeeds. That's why I added curl, to test if gnodev can be reach.
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
@D4ryl00 D4ryl00 requested a review from a team as a code owner April 30, 2024 21:20
@D4ryl00 D4ryl00 changed the title Feat/add gnodev dockerfile feat: add gnodev in the Dockerfile Apr 30, 2024
Dockerfile Outdated Show resolved Hide resolved
@moul
Copy link
Member

moul commented May 1, 2024

To speed up Docker builds, we can apply @D4ryl00's method for building contribs to build gnofaucet. This approach leverages cache reuse and streamlines the Go mod download process.

Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
@jefft0
Copy link
Contributor

jefft0 commented May 27, 2024

Status: Revisit when the docker support is updated.

@zivkovicmilos
Copy link
Member

@D4ryl00 can you pull in the latest master changes and resolve conflicts?

@zivkovicmilos zivkovicmilos marked this pull request as draft June 10, 2024 11:32
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.61%. Comparing base (931f3d2) to head (23aa04e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2009   +/-   ##
=======================================
  Coverage   54.61%   54.61%           
=======================================
  Files         581      581           
  Lines       77962    77962           
=======================================
  Hits        42579    42579           
  Misses      32205    32205           
  Partials     3178     3178           
Flag Coverage Δ
contribs/gnodev 23.81% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@D4ryl00
Copy link
Contributor Author

D4ryl00 commented Jun 13, 2024

@zivkovicmilos I've merged master and resolved conflicts.
@gfanton I put the Dockerfile in the contribs folder. Is it good for you?

@D4ryl00 D4ryl00 changed the title feat: add gnodev in the Dockerfile feat: add Dockerfile in the contribs folder with gnodev and gnofaucet Jun 13, 2024
@zivkovicmilos zivkovicmilos marked this pull request as ready for review June 13, 2024 11:50
@ajnavarro
Copy link
Contributor

@zivkovicmilos I think we should use goreleaser as we are doing for other contribs projects.

@D4ryl00
Copy link
Contributor Author

D4ryl00 commented Jun 26, 2024

We should use goreleaser instead of a Dockerfile to release gnodev and gnofaucet.

@D4ryl00 D4ryl00 closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants