-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnovm): add stacktraces and log them in panic messages #2145
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2145 +/- ##
==========================================
- Coverage 60.14% 60.09% -0.05%
==========================================
Files 560 560
Lines 74738 75035 +297
==========================================
+ Hits 44950 45093 +143
- Misses 26400 26556 +156
+ Partials 3388 3386 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b471ffc
to
3d1fcae
Compare
Thank you so much for this PR - this is super useful and is something that has been sitting on the backlog for way too long. I will make sure the team hears about this PR and takes a look as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry; this should be the last round of review.
Co-authored-by: Morgan <git@howl.moe>
… an error thrown when a panic is not handled in the realm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last naming thing. Everything else LGTM. 👏 👏 👏 👏
…rror` and change its `String()` method to `Error()`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #1812
Summary
This pull request introduces a new
StackTrace
mechanism to theMachine.Exceptions
class, enhancing its exception handling capabilities by generating and appending detailed stacktraces during panic situations.Panic Handling:
Code Example:
Sample Output:
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description