feat(examples): Implement p/demo/dequeue #2170
Conversation
linhpn99
requested review from
ajnavarro and
deelawn
and removed request for
a team
github-actions
bot
added
the
🧾 package/realm
|
@moul i have just implemented queue structure, please take a look ! |
| // PushFront adds an element to the front of the queue. | ||
| // Returns an error if the queue is full. | ||
| func (q *Queue) PushFront(value interface{}) error { | ||
| if q.begin-1 == q.end { |
There was a problem hiding this comment.
With q.begin (uint) set to 0 by default, you may encounter an issue here.
There was a problem hiding this comment.
I have tested this case, q.begin will equal max.Uint64 and does not cause any other runtime errors
| type Queue struct { | ||
| begin uint64 // Index of the front element | ||
| end uint64 // Index after the last element | ||
| data map[uint64]interface{} // Storage for queue elements |
There was a problem hiding this comment.
Using an AVL tree with SeqID appears preferable for optimizing storage efficiency at the moment.
|
You are adding general-purpose libraries, which is good. However, it's challenging to review without a real usage example. Could you create dapps using your new libraries or provide more actionable examples? |
linhpn99
changed the title
72cbc36 |
From issue : #2119
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description