fix(gnoweb): template and md style #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2223 +/- ##
=======================================
Coverage 49.93% 49.93%
=======================================
Files 576 576
Lines 77827 77827
=======================================
Hits 38864 38864
Misses 35839 35839
Partials 3124 3124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
reviewed
May 28, 2024
thehowl
reviewed
May 28, 2024
thehowl
reviewed
May 28, 2024
…o fix/global-md-styles
thehowl
reviewed
May 28, 2024
thehowl
approved these changes
May 28, 2024
thehowl
changed the title
leohhhn
approved these changes
May 28, 2024
omarsy
pushed a commit
to TERITORI/gno
that referenced
this pull request
Jun 3, 2024
This PR is a hotfix to markdown style. fixes: gnolang#1967 fixes: gnolang#2166 Maybe not the best way to handle it, but as we are gonna refactor gnoweb and pages are rendered as blog, what is not very clean, this is a quick fix before a better refactor. It create a `Kind` variable for rendered pages in `gnoweb`, that is used as CSS classname to wrap the body content. This is made to separate `Section` and `Page` contents: while first ones are created with a detailed architecture of sub-sections (invisible list, columns etc), the second kind is made for generic content. This separation allow to create different styles for the two kinds of structure we have on gno.land website: "page" one will have bullet lists, centered images etc by default and "section" one will be more transparent regarding the style. To achieve this, the PR creates a dedicated package for "events" instead of a blog rendered page (because this page is a `section`) and adds a default `page` CSS classname in blog content. In the future, we should use dedicated md / web components to display elements whatever the page type. --------- Co-authored-by: Morgan Bazalgette <morgan@morganbaz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a hotfix to markdown style.
fixes: #1967
fixes: #2166
Maybe not the best way to handle it, but as we are gonna refactor gnoweb and pages are rendered as blog, what is not very clean, this is a quick fix before a better refactor.
It create a
Kindvariable for rendered pages ingnoweb, that is used as CSS classname to wrap the body content. This is made to separateSectionandPagecontents: while first ones are created with a detailed architecture of sub-sections (invisible list, columns etc), the second kind is made for generic content.This separation allow to create different styles for the two kinds of structure we have on gno.land website:
"page" one will have bullet lists, centered images etc by default and "section" one will be more transparent regarding the style.
To achieve this, the PR creates a dedicated package for "events" instead of a blog rendered page (because this page is a
section) and adds a defaultpageCSS classname in blog content.In the future, we should use dedicated md / web components to display elements whatever the page type.