-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: rename foo/foo.md to foo/README.md in docs, update links #2258
base: master
Are you sure you want to change the base?
Conversation
…s-client/README.md
Not sure if good idea, but ChatGPT: Renaming a The README.md file is commonly recognized as the primary documentation entry point in many projects. By renaming foo.md to README.md, you are following a standard convention that makes it easier for others to quickly understand the purpose of the file and the content it holds when they navigate through the documentation tree. This can improve the overall clarity and organization of your documentation. |
this makes sense to me, seeing also as the urls on the website are not connected to the filename; but cc @leohhhn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense 👍
Could you do it for every index file for consistency? Each section has one.
Yep, I'll see if there are others! |
…re to avoid conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removing this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file got removed in c67eff6 (notice it's not in https://github.com/gnolang/gno/tree/master/docs/assets/how-to-guides anymore) but it was still present in my PR.
I got conflicts such as files deleted or removed on master since this PR was opened and tried to solve them manually.
I was actually reading about rebase vs merge workflows because of that.
Will review #2125, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed you removed several files. Was this intentional? The PR title no longer matches the changes. Please update it. I suggest reviewing #2125 as it's related and both are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review #2125 first, as I believe this PR conflicts with its final purpose.
Once there is a clear action plan for those two pull requests, please let me know, and I'll review this PR again.
Propose to rename it.