Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contribs): revert back to make <action>.<program> syntax instead of the opposite #2353

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Jun 13, 2024

Please, can we take a bit of care when modifying the syntaxes of our makefile commands?

They may not break code, but they break documentation and user flows. We can add a CI check as well; I see this for another PR as this is a hotfix. (Currently, running make install / make install.gnodev in the top-level directory doesn't work; because @moul inverted these in #1945). This is still not a substitute for a bit of good ol' attention in recognising when something is user-facing and thus should be changed with a bit more care and reason.

Note, I'm NOT saying that we should not change things, as we are before any 1.0 so we should change anything that makes sense; but it is a good practice that when changing a flag, command, etc., to do a global search for the old syntax to see examples where old documentation or untested code is broken.

@thehowl thehowl requested a review from moul June 13, 2024 14:58
@thehowl thehowl self-assigned this Jun 13, 2024
@thehowl thehowl requested a review from a team as a code owner June 13, 2024 14:58
@thehowl thehowl requested review from jaekwon and removed request for a team June 13, 2024 14:58
@thehowl thehowl changed the title fix(contribs): revert back to <action>.<program> syntax instead of the opposite fix(contribs): revert back to make <action>.<program> syntax instead of the opposite Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.61%. Comparing base (719ee92) to head (2da31bf).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2353   +/-   ##
=======================================
  Coverage   54.61%   54.61%           
=======================================
  Files         581      581           
  Lines       77962    77962           
=======================================
  Hits        42579    42579           
  Misses      32208    32208           
  Partials     3175     3175           
Flag Coverage Δ
contribs/gnodev 23.81% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajnavarro ajnavarro self-requested a review June 14, 2024 08:50
@thehowl thehowl merged commit 5fdbce0 into master Jun 17, 2024
51 checks passed
@thehowl thehowl deleted the dev/morgan/CONSISTENT-MAKEFILES branch June 17, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants