fix(ghverify): fix avl tree iteration in Render and GetFeedDefinitions
#2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2933 +/- ##
==========================================
- Coverage 60.97% 60.95% -0.02%
==========================================
Files 564 564
Lines 75273 75273
==========================================
- Hits 45897 45883 -14
- Misses 26008 26020 +12
- Partials 3368 3370 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
omarsy
force-pushed
the
fix/ghverify_iterate
branch
from
ed414e5
to
928010f
Compare
leohhhn
approved these changes
Oct 10, 2024
|
The title isn't clear. Could you please add a scope, such as To the reviewers, please be mindful of this. |
…r and GetFeedDefinitions function
omarsy
force-pushed
the
fix/ghverify_iterate
branch
from
928010f
to
2ba9aad
Compare
omarsy
changed the title
@moul |
thehowl
changed the title
Render and GetFeedDefinitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves a bug in the iteration logic of the
iteratefunction fromgno.land/p/demo/avl(avlTree) as used in two key areas: theRenderfunction ofgno.land/r/gnoland/ghverifyand theGetFeedDefinitionsfunction ofgno.land/p/demo/gnorkle/gnorkle.Problem:
In both instances, the
iteratefunction was returningtrueafter processing the first item, which prematurely halted the iteration. As a result, only the first item was processed, and all subsequent items were ignored.