-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updates for the faucet community bot #400
Conversation
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, as always.
Looks good to me 💯
Please resync this master branch with the current repo master
🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw lots of unwanted newline which can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I think the PR is great now. It just need to be updated with recent changes on master (p/demo/avl updates).
Then we can merge 👍
@moul can you review this? I made the changes required last month. thanks |
The code is to complete the example. We do not need to load it when starting gnoland. We will deploy the contract separately since it requires a large amount of deposit to fund the faucet when deploying the contract.
The deployment script is in https://github.com/gnolang/community-faucet-bot
#372
#362
#364