faucet realm package #372
Closed
faucet realm package #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
reviewed
Oct 30, 2022
moul
reviewed
Oct 30, 2022
moul
reviewed
Oct 30, 2022
| gInPause = false | ||
| gMessage = "# Community Faucet.\n\n" | ||
| gAdminAddr std.Address = "g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5" | ||
| gControllers [3]std.Address = [3]std.Address{} // limit it to 3 |
There was a problem hiding this comment.
Suggested change
| gControllers [3]std.Address = [3]std.Address{} // limit it to 3 | |
| gControllers []std.Address = []std.Address{} |
why a limit of 3?
There was a problem hiding this comment.
-
I think we should always use an array instead of a slice to limit resource usage to avoid abuse.
-
We can set the number to 100 if necessary. I think three faucet bot controllers are good enough for now, and we can replace each one of these controllers with provided API.
There was a problem hiding this comment.
I see your point, and it's a good idea to show good practices.
Let's update the limit to 10.
Suggested change
| gControllers [3]std.Address = [3]std.Address{} // limit it to 3 | |
| gControllers [10]std.Address = [10]std.Address{} // limit it to 10 |
moul
reviewed
Oct 30, 2022
moul
reviewed
Oct 30, 2022
moul
reviewed
Oct 30, 2022
moul
reviewed
Oct 30, 2022
moul
reviewed
Oct 30, 2022
moul
reviewed
Oct 30, 2022
moul
reviewed
Oct 30, 2022
moul
reviewed
Oct 30, 2022
moul
reviewed
Oct 30, 2022
|
Hey @piux2, Can you:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is to complete the example. We don't need to load it when starting test3 gnoland. We will deploy the contract separately since it requires a large amount of deposit to fund the faucet when deploying the contract.