fix(r/faucet): Render call panic #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbruyelle
commented
Mar 21, 2023
tbruyelle
commented
Mar 21, 2023
thehowl
reviewed
Mar 24, 2023
thehowl
approved these changes
Mar 24, 2023
|
@tbruyelle solid! Thank you for adding testing cases for rendering results. |
Fix gnolang#621 `Render` prints the controllers in a loop but relies on `gControllersSize` rather than `gControllers.Size()` to determine the number of controllers. The fix simply replaces `gControllersSize` by `gControllers.Size()`. Fix gnolang#627 filetest `Output:` directive doesn't work when the output contains multiple consecutive empty lines, because the method used to collect those comments truncate them (see issue and `ast.CommentGroup.Text()`). The fix replaces this method by a custom one that doesn't truncate.
Co-authored-by: Morgan <git@howl.moe>
|
Rebased on master, ready to merge. |
moul
approved these changes
Apr 3, 2023
grepsuzette
pushed a commit
to grepsuzette/gno
that referenced
this pull request
Apr 6, 2023
Co-authored-by: Morgan <git@howl.moe> Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #621
Renderprints the controllers in a loop but relies ongControllersSizerather thangControllers.Size()to determine the number of controllers. The fix simply replacesgControllersSizebygControllers.Size().Fix #627
filetest
Output:directive doesn't work when the output contains multiple consecutive empty lines, because the method used to collect those comments truncate them (see issue andast.CommentGroup.Text()). The fix replaces this method by a custom one that doesn't truncate.Note if it's preferable, I can split this PR because it fixes 2 different things. I did that because the second fix is required by the first one.