fix: assign contract owner upon contract deployment #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
changed the title
moul
reviewed
Nov 29, 2022
moul
reviewed
Nov 29, 2022
moul
reviewed
Nov 29, 2022
moul
reviewed
Nov 29, 2022
moul
reviewed
Nov 29, 2022
moul
reviewed
Nov 29, 2022
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
|
LGTM |
Thank you @anarcher |
moul
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue to fix:
There is a bug that prevents us from assigning the contract deployer as the contract owner. VM panics on a non-pointer interface error when we try to deploy a contract where we put the caller as contract owner in the init() function. The contract admin address is hardcoded in many contract examples as a workaround
Cause:
It turns out AddPackage does not set VM ExecContext in Keeper.
Two People Review Needed: Yes
Since the fix modifies vm/keeper.go, an extensive review is needed.