Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/gorilla/websocket from 1.4.2 to 1.5.0 #424

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 13, 2022

Bumps github.com/gorilla/websocket from 1.4.2 to 1.5.0.

Release notes

Sourced from github.com/gorilla/websocket's releases.

Minor new features and maintenance update

CHANGELOG

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Update to the dependencies label Dec 13, 2022
@dependabot dependabot bot requested a review from moul December 13, 2022 15:00
Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.4.2 to 1.5.0.
- [Release notes](https://github.com/gorilla/websocket/releases)
- [Commits](gorilla/websocket@v1.4.2...v1.5.0)

---
updated-dependencies:
- dependency-name: github.com/gorilla/websocket
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot-go_modules-master-github.com-gorilla-websocket-1.5.0 branch from 77bcb6e to f54fcca Compare December 14, 2022 00:43
@moul
Copy link
Member

moul commented Jan 19, 2023

Could someone review the changes (gorilla/websocket@v1.4.2...v1.5.0)?

Also, note that gorilla/websocket is now a "public archive" that won't be updated (https://github.com/gorilla#gorilla-toolkit).
Which can be a very great sign with our strategy of "finished" product.
But we need to also be prepared to patch security issues by ourselves or look for an alternative.

@zivkovicmilos
Copy link
Member

Could someone review the changes (gorilla/websocket@v1.4.2...v1.5.0)?

Also, note that gorilla/websocket is now a "public archive" that won't be updated (https://github.com/gorilla#gorilla-toolkit). Which can be a very great sign with our strategy of "finished" product. But we need to also be prepared to patch security issues by ourselves or look for an alternative.

@moul

I've looked through the changelog and there doesn't seem to be anything too fancy going on with this update. Here is the summary:

  • API change for TLS/TCP connections that better aligns with the standard net/http package
  • README update
  • Addition of some helper methods for struct manipulation
  • Expanded error messages for network frame parsing
  • Updated example code
  • Update to the broadcast benchmark code
  • Minor QoL updates to how TLS handshakes are handled
  • Swap for package constants instead of using string literals in http method names
  • Added build flags for earlier go versions (1.8)
  • Minor package comments for the Dialer and Upgrader structs
  • Echo example HTML css fix
  • Updated CircleCI config
  • Updated validation interface for type of connection

@moul moul merged commit 9542c3f into master Jan 25, 2023
@moul moul deleted the dependabot-go_modules-master-github.com-gorilla-websocket-1.5.0 branch January 25, 2023 17:52
harry-hov pushed a commit to harry-hov/gno that referenced this pull request Jan 27, 2023
…nolang#424)

Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.4.2 to 1.5.0.
- [Release notes](https://github.com/gorilla/websocket/releases)
- [Commits](gorilla/websocket@v1.4.2...v1.5.0)

---
updated-dependencies:
- dependency-name: github.com/gorilla/websocket
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@moul moul added this to the 💡Someday/Maybe milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update to the dependencies
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants