feat: add support for importing private key armor #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow up PR to #432, and it adds support for importing private key armor.
The command that's been added is:
gnokey import
The command assumes the private key armor being imported is encrypted.
Additionally, this PR also contains test cleanups for the
gnokey export
unit test, and changes to theKeyBase
interface methodImportPrivKey
to be analog toExportPrivKey
.Changes include
Checklist (for contributors)
Testing
Manual tests
In addition to a unit test covering this functionality, I've tested out the command using the following:
gnokey import --name NewKey --armor-path ~/gno-test.asc