Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused gnoview module #476

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

zivkovicmilos
Copy link
Member

Description

This PR removes the unused gnoview module. The module could not even be built due to outdated imports.
Additionally, it updates the build.yml by removing a comment related to gnoview.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist (for contributors)

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@zivkovicmilos zivkovicmilos added the 🐞 bug Something isn't working label Jan 23, 2023
@zivkovicmilos zivkovicmilos requested a review from a team as a code owner January 23, 2023 17:27
@zivkovicmilos zivkovicmilos self-assigned this Jan 23, 2023
@moul
Copy link
Member

moul commented Jan 24, 2023

@zivkovicmilos, before merging this, can you open an issue with reference to this PR + the parent commit hash tree view in the cmd/gnoview folder so it's easier to recycle the topic in the future?

Also, try to write a few words about the context if you can find it. I'll make sure to add some more lines, no worries.

@zivkovicmilos
Copy link
Member Author

@moul

Created a discussion about the gnoview functionality here:
#477

I've added the example that was removed with this PR, from the original commit hash

@moul
Copy link
Member

moul commented Jan 25, 2023

Thank you 👍

@moul moul merged commit afce2b5 into gnolang:master Jan 25, 2023
harry-hov pushed a commit to harry-hov/gno that referenced this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants