chore: precompile skip build tags if empty #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip adding build tags while precompiling a file if arg tags is empty. This saves us from error "parsing //go:build line: unexpected end of expression", if arg `tags` is empty. Also gives us the flexibility to skip build tags if needed. Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
harry-hov
added a commit
to harry-hov/gno
that referenced
this pull request
Jan 27, 2023
Skip adding build tags while precompiling a file if arg tags is empty. This saves us from error "parsing //go:build line: unexpected end of expression", if arg `tags` is empty. Also gives us the flexibility to skip build tags if needed. Signed-off-by: Hariom Verma <hariom.verma@tendermint.com> Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip adding build tags while precompiling a file if arg
tagsis empty. This saves us from errorparsing //go:build line: unexpected end of expression, iftagsis empty. Also gives us the flexibility to skip build tags if needed.