chore: add support for duration format for timeout flag #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
reviewed
Jan 27, 2023
moul
reviewed
Jan 27, 2023
zivkovicmilos
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Looks good 💯
Thank you for the contribution 🙏
I'm not a huge fan of using the reflect package, especially for something as simple as flag parsing, hopefully we can do away with that in #497
moul
approved these changes
Feb 2, 2023
moul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'timeout' flag of the test command now accepts human-readable duration format, such as '0.5s' or '1s' etc, in addition to the previous format of 'ns'. This change makes it more convenient for users to specify the execution time of the test command.
This change includes the following updates: