-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a ‘lib/demo/ui’ package #527
Conversation
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
I like the simplicity of the API thanks to the stringer interface, I think it's good enough but probably I lack experience in writing complex Can you elaborate a little bit more why would you prefer something like |
Thanks @tbruyelle 🙏 I may have gone overboard with defining too many structs/interfaces. Consolidating them into a single As for the API, we can merge it now and create a competing alternative |
Yes I'm for merging it now, so we can easily complement @alexiscolin's work like for Currently I had to rebase your branch and push it to my fork with the new commits, so how do you want to proceed for the PR? We can do it from my fork, or if you want it fron your fork, you can rebase and then cherry-pick my commit on jumbotron. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The goals are to provide a way to:
PS: I don’t like the current API, but I wanted to crash test something, then iterate.
I will probably switch to a single generic
type Element structOrInterface{Prepend, Set, Append}
.Opinions are appreciated.
Demo:
Addresses #903