Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support replacing module with another module #549

Merged
merged 7 commits into from
Mar 7, 2023
Merged

feat: support replacing module with another module #549

merged 7 commits into from
Mar 7, 2023

Conversation

harry-hov
Copy link
Contributor

@harry-hov harry-hov commented Feb 28, 2023 •
edited
Loading

Description

Currently, modules can only be replaced with a dir path. This PR adds support for replacing a module with another module.
e.g

replace (
        gno.land/p/demo/bank v1.2.3  => gno.land/p/demo/bank v2.3.4
        gno.land/p/demo/avlll v0.0.0  => gno.land/p/demo/avl v0.0.0
)

How has this been tested?

Tests and manually

Related: #462

@harry-hov harry-hov marked this pull request as ready for review March 1, 2023 07:18
@harry-hov harry-hov requested a review from a team as a code owner March 1, 2023 07:18
@harry-hov harry-hov self-assigned this Mar 1, 2023
zivkovicmilos
zivkovicmilos approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

I've left a few questions, nothing major

pkgs/gnolang/gnomod/read.go Show resolved Hide resolved
pkgs/gnolang/gnomod/read.go Show resolved Hide resolved
pkgs/gnolang/gnomod/gnomod.go Outdated Show resolved Hide resolved
zivkovicmilos
zivkovicmilos approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

I've left a few questions, nothing major

@zivkovicmilos
Copy link
Member

Looks great 💯

I've left a few questions, nothing major

GitHub being GitHub 🙂

Screenshot 2023-03-02 at 18 22 35

@harry-hov harry-hov marked this pull request as draft March 6, 2023 15:20
moul
moul reviewed Mar 6, 2023
View reviewed changes
pkgs/gnolang/gnomod/gnomod.go Outdated Show resolved Hide resolved
@harry-hov harry-hov force-pushed the hariom/gno.mod-replace branch 2 times, most recently from 8982ab6 to 4160b88 Compare March 6, 2023 19:24
@harry-hov harry-hov marked this pull request as ready for review March 6, 2023 22:44
@harry-hov
Copy link
Contributor Author

harry-hov commented Mar 6, 2023 •
edited
Loading

Sorry I needed to rebase and force push. Only the last 2 commits are new. The rest are same.

@moul moul merged commit 84b2f48 into gnolang:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@moul moul moul left review comments

Assignees

@harry-hov harry-hov

Labels
None yet
Projects
🚀 The Launch [DEPRECATED]
Status: 🔵 Not Needed for Launch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harry-hov @zivkovicmilos @moul