Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: set correct deposit flag in flagset for addpkg #578

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

zivkovicmilos
Copy link
Member

Description

This PR fixes a single incorrectly set flag for maketx addpkg.
I've scanned over all of the other commands and subcommands, this is the single flag that was not set properly.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist (for contributors)

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Manually executed a maketx addpkg command that made sure deposit was set, ex:

./build/gnokey maketx addpkg \
--pkgpath "gno.land/p/demo/stack" \
--pkgdir "examples/gno.land/p/demo/stack" \
--deposit 100000000ugnot \
--gas-fee 1000000ugnot \
--gas-wanted 2000000 \
--broadcast \
--chainid dev \
--remote localhost:26657 \
UserKey

Additional Comments

Noticed while executing command from #576

@zivkovicmilos zivkovicmilos added the hotfix Major bug fix that should be merged ASAP label Mar 9, 2023
@zivkovicmilos zivkovicmilos self-assigned this Mar 9, 2023
@zivkovicmilos zivkovicmilos requested a review from a team as a code owner March 9, 2023 11:10
@moul moul merged commit b5a664f into gnolang:master Mar 9, 2023
@zivkovicmilos zivkovicmilos deleted the hotfix/incorrect-addpkg-flag branch March 9, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix Major bug fix that should be merged ASAP
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants