Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[performance] compile regexes globally #633

Merged
merged 2 commits into from
Mar 22, 2023
Merged

[performance] compile regexes globally #633

merged 2 commits into from
Mar 22, 2023

Conversation

peter7891
Copy link
Contributor

This is a small PR in line of work suggested here
To avoid compiling these static regexes on every function call, we compile them on the package level, once.

@peter7891 peter7891 requested a review from a team as a code owner March 22, 2023 15:09
zivkovicmilos
zivkovicmilos approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good 💯

pkgs/gnolang/helpers.go Outdated Show resolved Hide resolved
@peter7891 peter7891 merged commit f8fce91 into master Mar 22, 2023
@peter7891 peter7891 deleted the compile-regex branch March 22, 2023 17:31
peter7891 added a commit that referenced this pull request Mar 29, 2023
@peter7891
[performance] compile regexes globally (#633)
b31824e 
* compile regexes globally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

Assignees

@peter7891 peter7891

Labels
None yet
Projects
🚀 The Launch [DEPRECATED]
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter7891 @zivkovicmilos