refactor(gnovm): consistent map type evaluation for *IndexExpr #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix works. However, we should use baseOf() function to have a consistent implementation when we retrieve the base type of a declared type
piux2
changed the title
moul
approved these changes
Apr 5, 2023
thehowl
approved these changes
Apr 18, 2023
thehowl
changed the title
peter7891
pushed a commit
that referenced
this pull request
May 9, 2023
Consistent map type evaluation for *IndexExpr The previous fix works. However, we should use baseOf() function to have a consistent implementation when we retrieve the base type of a declared type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous fix works. However, we should use the existing baseOf() function for a consistent implementation when we retrieve the base type of a declared type
How has this been tested?
Same test for the previous fix
tests/files/map28c.gno