Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove old build constraints (ie. "+build") #746

Merged
merged 2 commits into from
Apr 16, 2023
Merged

chore: remove old build constraints (ie. "+build") #746

merged 2 commits into from
Apr 16, 2023

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Apr 14, 2023

@thehowl thehowl requested a review from a team as a code owner April 14, 2023 15:16
moul
moul approved these changes Apr 15, 2023
View reviewed changes
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I hope all the linters will look at our minimal version :)

@moul moul merged commit f118d92 into gnolang:master Apr 16, 2023
68 checks passed
@thehowl thehowl deleted the dev/morgan/remove-old-build-constraint branch May 8, 2023 14:57
peter7891 pushed a commit that referenced this pull request May 9, 2023
@thehowl @peter7891
chore: remove old build constraints (ie. "+build") (#746)
81fd3eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbruyelle tbruyelle tbruyelle approved these changes

@moul moul moul approved these changes

Assignees

@thehowl thehowl

Labels
None yet
Projects
🚀 The Launch
Status: No status
🧐 Review Meeting
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thehowl @tbruyelle @moul