Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto migrate old gno home to new #759

Merged
merged 3 commits into from
May 3, 2023

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Apr 19, 2023

See #719 .

I think we should do this to ease the migration during test4.

An alternative for me would be to not auto-move it but show a warning.

What do you guys think?

@thehowl thehowl requested a review from a team as a code owner April 19, 2023 17:01
@moul
Copy link
Member

moul commented Apr 20, 2023

I think we should either not do it or make it in a more isolated place, like migration.go, so the main codebase stays more focused on the essentials. Can you give a try?

@thehowl
Copy link
Member Author

thehowl commented Apr 20, 2023

Done 👍

Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we open an issue to effectively remove this code after releasing test4?

@moul moul merged commit 299035d into gnolang:master May 3, 2023
59 checks passed
peter7891 pushed a commit that referenced this pull request May 9, 2023
moul-bot pushed a commit that referenced this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants