feat: add Sine + Cosine + Signbit #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version of sin.go comes from pre Go1. Futures versions rely on unsafe which is not yet implemented in gnovm
Open
albttx
reviewed
May 9, 2023
|
@albttx Yes, it never hurts! I can add some tests. |
|
Tests added for |
zivkovicmilos
approved these changes
May 15, 2023
albttx
approved these changes
May 15, 2023
ajnavarro
approved these changes
May 15, 2023
|
I suggest adding a new compatibility documentation file and using this PR as an example for updating helpers while maintaining the compatibility matrix. Please wait a bit longer before merging. |
ajnavarro
added
🌱 feature
|
Can you update this file: https://github.com/gnolang/gno/blob/master/gnovm/docs/go-gno-compatibility.md#stdlibs? |
schollz
added a commit
to schollz/gno
that referenced
this pull request
May 22, 2023
github-actions
bot
added
📦 🤖 gnovm
Yes! Added now. |
|
reading now |
|
pinging @moul with the final vote to merge this. |
moul
approved these changes
Jun 6, 2023
Doozers
pushed a commit
to Doozers/gno
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds in the
math.Sinandmath.Cosmethods. This file is from the Pre-Go 1 history: https://github.com/golang/go/blob/e4de2e7fd04c92d4035cd268d5043f2380aef437/src/pkg/math/sin.go The future versions had trouble with the gno language due to unsupported features.How has this been tested?
Yes, I am using it in a realm that I am working on (https://github.com/schollz/gno/tree/bytebeat). There are no tests for the math packages, but I can add tests if needed.