Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new website v2 #818

Merged
merged 55 commits into from
Jul 4, 2023
Merged

feat: new website v2 #818

merged 55 commits into from
Jul 4, 2023

Conversation

alexiscolin
Copy link
Member

@alexiscolin alexiscolin commented May 10, 2023

Gno Website Design V2

This PR aims to deliver a new website layout design by sync the www.gno.land repo (used for static contents on Gno main website). It adds more flexibility and (HTML/CSS) components that will be decoupled and reuse in #781 with dedicated markdown markup.
As of today, changes mainly involve Markdown and CSS files, but some Go templates have been updated (such as header menu, blogs listing...)

  • New Fonts
  • Navigation
  • New Home page
  • New Blog page
  • New Event page
  • New About page
  • Packages pages
  • Responsive navigation
  • Columns (2 / 3) component
  • Jumbotron component
  • Accordion component
  • Tabs component
  • Stack component
  • New dedicated GoR page
  • Email form design
  • CSS cleanup (variables / relative units ...)

⚠️ Note: This is a draft and the render has not been tested everywhere or in every situation yet.

@alexiscolin alexiscolin requested a review from a team as a code owner May 10, 2023 15:48
@alexiscolin alexiscolin marked this pull request as draft May 10, 2023 15:48
@ajnavarro
Copy link
Contributor

Would be great to be able to see a render somewhere.

@tbruyelle
Copy link
Contributor

tbruyelle commented May 11, 2023

Would be great to be able to see a render somewhere.

You can run the website locally:

$ cd gno.land
$ go run ./cmd/gnoweb
Running on http://127.0.0.1:8888

(after having pulled this branch ofc)

@thehowl
Copy link
Member

thehowl commented May 12, 2023

You can run the website locally:

Yes indeed, but for convenience I also made a small screencast of the current state of the website :)

https://drop.howl.moe/e75fb57f97-2023-05-12_11-36-10.mp4

Great work @alexiscolin !

@alexiscolin
Copy link
Member Author

Here is a new preview (Desktop ver)

23-05-17_gno.land.mp4

@alexiscolin
Copy link
Member Author

And the Mobile ver

23-05-17_gno.land-mob.mp4

@github-actions github-actions bot added 📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages. labels May 18, 2023
@alexiscolin alexiscolin requested a review from moul June 12, 2023 12:15
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screencast of my clicking around the new website: https://drop.howl.moe/4f1921404c-2023-06-15_19-59-54.mp4

It looks good, I have some general comments aside the code-specific ones:

  1. Can we make the sun/moon icon for the theme switcher the same color as the GitHub icon in the header?
  2. I see we render a <hr> we don't really use at the bottom. Can we remove it?
  3. Maybe we should add some spacing on the <pre> / code blocks to make them nicer aesthetically?
  4. Should we have something, when viewing a realm render, to visually distinguish the realm and path + source/help links at the top? I know they're already full-size compared to the content -- but maybe make them have a slightly darker background, in transition from the header's background?
  5. I think the "Socials" section in the homepage footer has a lot of negative space on desktop. Maybe have the subscribe form on the right?

examples/gno.land/p/demo/blog/blog.gno Outdated Show resolved Hide resolved
gno.land/cmd/gnoweb/static/js/renderer.js Outdated Show resolved Hide resolved
gno.land/cmd/gnoweb/static/js/renderer.js Show resolved Hide resolved
gno.land/cmd/gnoweb/views/faucet.html Outdated Show resolved Hide resolved
@alexiscolin
Copy link
Member Author

@moul I've updated the content as we discussed yesterday. I've added two static pages "ecosystem" and "language" that follow the generic template.

I've also removed the Events and GoR contents. So I will let you push the data onchain, then I will probably need help to retrieve and display them. For the record, as I've removed these pages, you can find their display architecture in this commit.

Here is the contents:

@alexiscolin alexiscolin marked this pull request as ready for review June 29, 2023 00:30
@alexiscolin
Copy link
Member Author

@moul for the testnet style merge,

  • I've quickly reset the main pages to keep them simple (HOME, GOR...)
  • I've removed all static pages that are not necessary cause embedded intro www.gno.land repo
  • I've sync the static repo style with this one

Be careful about the style render into blog article since it hasn't been fully tested with long and complex article (with all the exotic md syntax yet)

Could be great to take a look at sources and help content as well. I've checked them but maybe some exotic content I'm not aware of are hidden in the contents.

moul added 3 commits July 4, 2023 16:13
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul merged commit dd78209 into gnolang:master Jul 4, 2023
Doozers pushed a commit to Doozers/gno that referenced this pull request Aug 31, 2023
Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: 🚀 Needed for Launch
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants