Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: set up Codecov #819

Merged
merged 11 commits into from
May 17, 2023
Merged

test: set up Codecov #819

merged 11 commits into from
May 17, 2023

Conversation

moul
Copy link
Member

@moul moul commented May 12, 2023 •
edited by zivkovicmilos
Loading

Description

Add Codecov support for tm2, gnovm, gno.land.

Related to #572.

Contributors Checklist

  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

Maintainers Checklist

  • Checked that the author followed the guidelines in CONTRIBUTING.md
  • Checked the conventional-commit (especially PR title and verb, presence of BREAKING CHANGE: in the body)
  • Ensured that this PR is not a significant change or confirmed that the review/consideration process was appropriate for the change

@moul moul requested a review from a team as a code owner May 12, 2023 17:11
@moul moul changed the title chore(tm2): setup codecov WIP chore(tm2): setup codecov May 12, 2023
@zivkovicmilos zivkovicmilos self-requested a review May 12, 2023 19:09
moul added 4 commits May 13, 2023 06:46
@moul
chore: fixup
84b2c52 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: fixup
da5356c 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: fixup
9b921f9 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: fixup
b63c14c 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul marked this pull request as draft May 13, 2023 05:07
@moul
chore: fixup
d298ecc 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul changed the title WIP chore(tm2): setup codecov WIP chore: set up Codecov May 13, 2023
@moul
chore: fixup
29e3cf1 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul changed the title WIP chore: set up Codecov chore: set up Codecov May 13, 2023
@moul
chore: fixup
08ea348 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul marked this pull request as ready for review May 13, 2023 06:54
moul added 3 commits May 13, 2023 09:00
@moul
chore: fixup
c5adf34 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: fixup
a97c0e4 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: fixup
48ad572 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul changed the title chore: set up Codecov test: set up Codecov May 13, 2023
@gnolang gnolang deleted a comment from codecov bot May 13, 2023
zivkovicmilos
zivkovicmilos approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

I would probably add a Codecov badge to the README for easy reference, if we want that right now

.github/workflows/gnoland.yml Show resolved Hide resolved
@moul moul merged commit 3838a2f into master May 17, 2023
@moul moul deleted the dev/moul/tm2-cover branch May 17, 2023 10:37
moul-bot pushed a commit that referenced this pull request May 19, 2023
@moul
test: set up Codecov (#819)
583dcf5
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@thehowl thehowl Awaiting requested review from thehowl

@ajnavarro ajnavarro Awaiting requested review from ajnavarro

Assignees

@moul moul

Labels
None yet
Projects
😎 Manfred's Board
Status: ✅ Done
🚀 The Launch [DEPRECATED]
Archived in project
🧐 Review Meeting
Archived in project
Milestone
DEPRECATED:🌟 main.gno.land (wanted)
Development

Successfully merging this pull request may close these issues.
2 participants
@moul @zivkovicmilos