Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add p/demo/mux #882

Merged
merged 11 commits into from
Jun 20, 2023
Merged

feat: add p/demo/mux #882

merged 11 commits into from
Jun 20, 2023

Conversation

moul
Copy link
Member

@moul moul commented Jun 8, 2023

Add a simple mux/router system for Render().
Update the p/demo/blog package accordingly.
Inspired by #866 which aims to offer an all-in-one framework.

Not sure if should be p/demo/mux or p/demo/router. Idea?

Contributors Checklist

  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

Maintainers Checklist

  • Checked that the author followed the guidelines in CONTRIBUTING.md
  • Checked the conventional-commit (especially PR title and verb, presence of BREAKING CHANGE: in the body)
  • Ensured that this PR is not a significant change or confirmed that the review/consideration process was appropriate for the change

moul added 2 commits June 8, 2023 22:18
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul self-assigned this Jun 8, 2023
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jun 8, 2023
moul added 3 commits June 8, 2023 22:27
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul changed the title dev/moul/mux feat: add p/demo/mux Jun 8, 2023
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jun 8, 2023
moul added 3 commits June 8, 2023 17:44
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul marked this pull request as ready for review June 8, 2023 16:23
@moul moul requested a review from a team as a code owner June 8, 2023 16:23
@harry-hov harry-hov self-requested a review June 16, 2023 11:23
@github-actions github-actions bot removed the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jun 20, 2023
Copy link
Contributor

@harry-hov harry-hov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add gno.mod file. Rest LGTM 💯

@moul
Copy link
Member Author

moul commented Jun 20, 2023

Just add gno.mod file. Rest LGTM 💯

$ moul in 🌐 crux in  2 ~/g/s/g/g/g/e/g/p/demo/ui  dev/moul/mux   via  v1.20.3 gno mod init
USAGE
  mod <command>

SUBCOMMANDS
  download  Download modules to local cache

ohhhh :)


Edit(@harry-hov): Soon!

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@harry-hov
Copy link
Contributor

harry-hov commented Jun 20, 2023

Just one last thing. Add gno.land/p/demo/mux as dependency in p/demo/blog/gno.mod

PS: please bear until gno mod tidy :)

@moul
Copy link
Member Author

moul commented Jun 20, 2023

done

@harry-hov
Copy link
Contributor

Merging this for now. If we come up with a better name, we can change it in another PR.

@harry-hov harry-hov merged commit 55d4aba into gnolang:master Jun 20, 2023
Doozers pushed a commit to Doozers/gno that referenced this pull request Aug 31, 2023
Add a simple mux/router system for Render().
Update the p/demo/blog package accordingly.
@moul moul added this to the 🚀 main.gno.land (required) milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: ✅ Done
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants