fix(tm2): better error on AddPackage when package already exists #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of 'internal error' and a long stack trace, now we have an understandable output 'package already exists: pkg/name' Also added cmnError.Unwrap() for compatibility with stdlib.
tbruyelle
force-pushed
the
fix/addPkg-error
branch
from
f719ccd
to
c7272b2
Compare
moul
approved these changes
Jun 27, 2023
|
LGTM 👍 Next times, share before/after result, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of 'internal error' and a long stack trace, now we have an understandable output 'package already exists: pkg/name'
Also added cmnError.Unwrap() for compatibility with stdlib.
Contributors Checklist
BREAKING CHANGE: xxxmessage was included in the descriptionMaintainers Checklist
CONTRIBUTING.mdBREAKING CHANGE:in the body)