-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transaction filter #5
Conversation
Hey @notJoon, Thank you for the PR 🙏 I apologize for the late reply on this, it slipped through my notifications. |
I think we can avoid applying filters with elements on memory and do it directly using pebbleDB and their properties to iterate through keys in order. Have a look at #12 . This approach can evolve even more adding secondary indexes. Not needed right now because queries take less than 20ms. |
yeah, I think that would be much efficient than this filtering things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution 🙏
Even though this PR doesn't contain connecting logic with the RPC layer, I see it as a good foundation for v1 of transaction filtering.
I've left some comments that should be addressed, I think we can greatly simplify the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
Thank you for addressing the comments 🙏
I've left a few suggestions, otherwise it looks good to go
Hey @notJoon, what's the status on this PR? Did you get a chance to check the comments? |
I apologize for the late reply. I should be able to get it all done by in this weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll open up a PR with @ajnavarro to connect this out with the RPC layer
Thank you for resolving the convos 🙏
Description
Created a transaction filter. The structure is largely similar to a block filter since it was referenced, but it is designed to enable search for each data using
TxResult
.Additionally, I utilized the method chaining to implement a query-like search. This allows the application of complex filtering criteria in a simplified manner.
Example Usage