-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would these also be affected?
(<Trans>{priceImpact.multiply(-1).toSignificant(3)}%</Trans>) <ClickableText onClick={toggleSettings}>{allowedSlippage.toFixed(2)}%</ClickableText>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alfetopito , we have related low priority UI issue with price impact #1148 : could you please take a look at it in this pr as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
First one, is literally the one I had changed XD |
This should probably be fixed after I merge #1281 |
38bda72
to
abc83f9
Compare
It was! Take a look now. |
Great! Fixed! Thanks |
abc83f9
to
f3bf69f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED AGAIN
# Summary Closes #999 Closes #1148 2 decimals precision for price impact ![screenshot_2021-08-25_13-35-08](https://user-images.githubusercontent.com/43217/130860763-3c212bf4-04ba-4e69-b137-025a3a245a47.png) # To Test 1. Fill in all inputs while on Mainnet or xDai * Observe price impact is limited to 2 decimals precision * When percentage < 0.01, it shows `< 0.01` * It does not display insignificant zeros: 0.90 => 0.9
# Summary Closes #999 Closes gnosis/cowswap#1148 2 decimals precision for price impact ![screenshot_2021-08-25_13-35-08](https://user-images.githubusercontent.com/43217/130860763-3c212bf4-04ba-4e69-b137-025a3a245a47.png) # To Test 1. Fill in all inputs while on Mainnet or xDai * Observe price impact is limited to 2 decimals precision * When percentage < 0.01, it shows `< 0.01` * It does not display insignificant zeros: 0.90 => 0.9
Summary
Closes #999
Closes #1148
2 decimals precision for price impact
To Test
< 0.01